Vertex AI Gemini: support system messages and parallel tools/functions #1141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
glaforge
commented
May 22, 2024
glaforge
commented
- support system instructions
- support parallel function calling
- should avoid the allocation issue faced sometimes because of the lifecycle of the underlying VertexAI client object
langchain4j
reviewed
May 22, 2024
.idea/icon.png
Outdated
...vertex-ai-gemini/src/test/java/dev/langchain4j/model/vertexai/VertexAiGeminiChatModelIT.java
Outdated
Show resolved
Hide resolved
...-gemini/src/test/java/dev/langchain4j/model/vertexai/VertexAiGeminiStreamingChatModelIT.java
Outdated
Show resolved
Hide resolved
- support system instructions - support parallel function calling - should avoid the allocation issue faced sometimes because of the lifecycle of the underlying VertexAI client object
- add test for parallel function calling
- use only one model as vision and non-vision are only a single model now
langchain4j
approved these changes
May 22, 2024
langchain4j
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.